Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)
Patch Set: +DISALLOW_COPY_AND_ASSIGN for win build fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
index c278799fa45b7f4f83c549e7b3bd6faee0674156..81bfe19a4e8b31e9128a621cdd55de0c9b5fb4ee 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
@@ -67,8 +67,8 @@ class HTMLParserScheduler final
public:
static HTMLParserScheduler* create(HTMLDocumentParser* parser,
- WebTaskRunner* loadingTaskRunner) {
- return new HTMLParserScheduler(parser, loadingTaskRunner);
+ RefPtr<WebTaskRunner> loadingTaskRunner) {
+ return new HTMLParserScheduler(parser, std::move(loadingTaskRunner));
}
~HTMLParserScheduler();
@@ -93,13 +93,13 @@ class HTMLParserScheduler final
DECLARE_TRACE();
private:
- HTMLParserScheduler(HTMLDocumentParser*, WebTaskRunner*);
+ HTMLParserScheduler(HTMLDocumentParser*, RefPtr<WebTaskRunner>);
bool shouldYield(const SpeculationsPumpSession&, bool startingScript) const;
void continueParsing();
Member<HTMLDocumentParser> m_parser;
- std::unique_ptr<WebTaskRunner> m_loadingTaskRunner;
+ RefPtr<WebTaskRunner> m_loadingTaskRunner;
TaskHandle m_cancellableContinueParseTaskHandle;
bool m_isSuspendedWithActiveTimer;

Powered by Google App Engine
This is Rietveld 408576698