third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp - Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp

Issue 2550373005: Make WebTaskRunner ThreadSafeRefCounted (Closed)

Patch Set: +DISALLOW_COPY_AND_ASSIGN for win build fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp b/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp

index 152defdd0dc07dff6417ef9503560f945bfb48e7..49b3dbea18446ecdd49dc60e213f9f219e3293d8 100644

--- a/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp

@@ -88,7 +88,7 @@ static void checkThatXSSInfosAreSafeToSendToAnotherThread(

WeakPtr<BackgroundHTMLParser> BackgroundHTMLParser::create(

std::unique_ptr<Configuration> config,

- std::unique_ptr<WebTaskRunner> loadingTaskRunner) {

+ RefPtr<WebTaskRunner> loadingTaskRunner) {

auto* backgroundParser =

new BackgroundHTMLParser(std::move(config), std::move(loadingTaskRunner));

return backgroundParser->m_weakFactory.createWeakPtr();

@@ -109,7 +109,7 @@ BackgroundHTMLParser::Configuration::Configuration()

BackgroundHTMLParser::BackgroundHTMLParser(

std::unique_ptr<Configuration> config,

- std::unique_ptr<WebTaskRunner> loadingTaskRunner)

+ RefPtr<WebTaskRunner> loadingTaskRunner)

: m_weakFactory(this),

m_token(WTF::wrapUnique(new HTMLToken)),

m_tokenizer(HTMLTokenizer::create(config->options)),