Make WebTaskRunner ThreadSafeRefCounted

third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/ScriptStreamer.h"
 
 #include "bindings/core/v8/ScriptStreamerThread.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 157 matching lines @@
 };
 
 // SourceStream implements the streaming interface towards V8. The main
 // functionality is preparing the data to give to V8 on main thread, and
 // actually giving the data (via GetMoreData which is called on a background
 // thread).
 class SourceStream : public v8::ScriptCompiler::ExternalSourceStream {
   WTF_MAKE_NONCOPYABLE(SourceStream);
 
  public:
-  explicit SourceStream(WebTaskRunner* loadingTaskRunner)
+  explicit SourceStream(RefPtr<WebTaskRunner> loadingTaskRunner)
       : v8::ScriptCompiler::ExternalSourceStream(),
         m_cancelled(false),
         m_finished(false),
         m_queueLeadPosition(0),
         m_queueTailPosition(0),
-        m_loadingTaskRunner(loadingTaskRunner->clone()) {}
+        m_loadingTaskRunner(std::move(loadingTaskRunner)) {}
 
   virtual ~SourceStream() override {}
 
   // Called by V8 on a background thread. Should block until we can return
   // some data.
   size_t GetMoreData(const uint8_t** src) override {
     DCHECK(!isMainThread());
     {
       MutexLocker locker(m_mutex);
       if (m_cancelled)
@@ skipping 115 matching lines @@
   RefPtr<const SharedBuffer> m_resourceBuffer;  // Only used by the main thread.
 
   // The queue contains the data to be passed to the V8 thread.
   //   queueLeadPosition: data we have handed off to the V8 thread.
   //   queueTailPosition: end of data we have enqued in the queue.
   //   bookmarkPosition: position of the bookmark.
   SourceStreamDataQueue m_dataQueue;  // Thread safe.
   size_t m_queueLeadPosition;         // Only used by v8 thread.
   size_t m_queueTailPosition;  // Used by both threads; guarded by m_mutex.
 
-  std::unique_ptr<WebTaskRunner> m_loadingTaskRunner;
+  RefPtr<WebTaskRunner> m_loadingTaskRunner;
 };
 
 size_t ScriptStreamer::s_smallScriptThreshold = 30 * 1024;
 
 void ScriptStreamer::startStreaming(PendingScript* script,
                                     Type scriptType,
                                     Settings* settings,
                                     ScriptState* scriptState,
-                                    WebTaskRunner* loadingTaskRunner) {
+                                    RefPtr<WebTaskRunner> loadingTaskRunner) {
   // We don't yet know whether the script will really be streamed. E.g.,
   // suppressing streaming for short scripts is done later. Record only the
   // sure negative cases here.
   bool startedStreaming = startStreamingInternal(
-      script, scriptType, settings, scriptState, loadingTaskRunner);
+      script, scriptType, settings, scriptState, std::move(loadingTaskRunner));
   if (!startedStreaming)
     recordStartedStreamingHistogram(scriptType, 0);
 }
 
 bool ScriptStreamer::convertEncoding(
     const char* encodingName,
     v8::ScriptCompiler::StreamedSource::Encoding* encoding) {
   // Here's a list of encodings we can use for streaming. These are
   // the canonical names.
   if (strcmp(encodingName, "windows-1252") == 0 ||
@@ skipping 171 matching lines @@
   m_loadingFinished = true;
 
   notifyFinishedToClient();
 }
 
 ScriptStreamer::ScriptStreamer(
     PendingScript* script,
     Type scriptType,
     ScriptState* scriptState,
     v8::ScriptCompiler::CompileOptions compileOptions,
-    WebTaskRunner* loadingTaskRunner)
+    RefPtr<WebTaskRunner> loadingTaskRunner)
     : m_pendingScript(script),
       m_resource(script->resource()),
       m_detached(false),
       m_stream(0),
       m_loadingFinished(false),
       m_parsingFinished(false),
       m_haveEnoughDataForStreaming(false),
       m_streamingSuppressed(false),
       m_compileOptions(compileOptions),
       m_scriptState(scriptState),
       m_scriptType(scriptType),
       m_scriptURLString(m_resource->url().copy().getString()),
       m_scriptResourceIdentifier(m_resource->identifier()),
       // Unfortunately there's no dummy encoding value in the enum; let's use
       // one we don't stream.
       m_encoding(v8::ScriptCompiler::StreamedSource::TWO_BYTE),
-      m_loadingTaskRunner(loadingTaskRunner->clone()) {}
+      m_loadingTaskRunner(std::move(loadingTaskRunner)) {}
 
 ScriptStreamer::~ScriptStreamer() {}
 
 DEFINE_TRACE(ScriptStreamer) {
   visitor->trace(m_pendingScript);
   visitor->trace(m_resource);
 }
 
 void ScriptStreamer::streamingComplete() {
   // The background task is completed; do the necessary ramp-down in the main
@@ skipping 23 matching lines @@
   // completed. Here we also check that we have a client: it can happen that a
   // function calling notifyFinishedToClient was already scheduled in the task
   // queue and the upper layer decided that it's not interested in the script
   // and called removeClient.
   if (!isFinished())
     return;
 
   m_pendingScript->streamingFinished();
 }
 
-bool ScriptStreamer::startStreamingInternal(PendingScript* script,
-                                            Type scriptType,
-                                            Settings* settings,
-                                            ScriptState* scriptState,
-                                            WebTaskRunner* loadingTaskRunner) {
+bool ScriptStreamer::startStreamingInternal(
+    PendingScript* script,
+    Type scriptType,
+    Settings* settings,
+    ScriptState* scriptState,
+    RefPtr<WebTaskRunner> loadingTaskRunner) {
   DCHECK(isMainThread());
   DCHECK(scriptState->contextIsValid());
   ScriptResource* resource = script->resource();
   if (resource->isLoaded()) {
     recordNotStreamingReasonHistogram(scriptType, AlreadyLoaded);
     return false;
   }
   if (!resource->url().protocolIsInHTTPFamily()) {
     recordNotStreamingReasonHistogram(scriptType, NotHTTP);
     return false;
@@ skipping 13 matching lines @@
   // produce parser cache if the non-streaming compile takes advantage of it.
   v8::ScriptCompiler::CompileOptions compileOption =
       v8::ScriptCompiler::kNoCompileOptions;
   if (settings->getV8CacheOptions() == V8CacheOptionsParse)
     compileOption = v8::ScriptCompiler::kProduceParserCache;
 
   // The Resource might go out of scope if the script is no longer
   // needed. This makes PendingScript notify the ScriptStreamer when it is
   // destroyed.
   script->setStreamer(ScriptStreamer::create(script, scriptType, scriptState,
-                                             compileOption, loadingTaskRunner));
+                                             compileOption,
+                                             std::move(loadingTaskRunner)));
 
   return true;
 }
 
 }  // namespace blink