Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2550333003: Update CertVerifyProcTest.LargeKey for Sierra (Mac OS 10.12) (Closed)

Created:
4 years ago by mattm
Modified:
4 years ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update CertVerifyProcTest.LargeKey for Sierra (Mac OS 10.12) On 10.12 a large key causes a recoverable error instead of a fatal error, and one of the chain status codes is CSSMERR_TP_NOT_TRUSTED, so the cert_status is now (CERT_STATUS_AUTHORITY_INVALID | CERT_STATUS_INVALID). Update the test to just check if CERT_STATUS_INVALID is present in cert_status so that it will pass on any version of mac. BUG=629712 Committed: https://crrev.com/99c0d7490554f43ed1b14d315a39be5f4c5e3fc0 Cr-Commit-Position: refs/heads/master@{#436714}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M net/cert/cert_verify_proc_unittest.cc View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 15 (8 generated)
mattm
4 years ago (2016-12-06 02:35:44 UTC) #4
davidben
lgtm https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode1952 net/cert/cert_verify_proc_unittest.cc:1952: // on 10.12. Perhaps a certificate with a ...
4 years ago (2016-12-06 19:47:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550333003/1
4 years ago (2016-12-06 20:41:17 UTC) #9
mattm
https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode1952 net/cert/cert_verify_proc_unittest.cc:1952: // on 10.12. On 2016/12/06 19:47:49, davidben wrote: > ...
4 years ago (2016-12-06 20:42:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 20:53:51 UTC) #12
davidben
On 2016/12/06 20:42:45, mattm wrote: > https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc > File net/cert/cert_verify_proc_unittest.cc (right): > > https://codereview.chromium.org/2550333003/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode1952 > ...
4 years ago (2016-12-06 20:56:43 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 20:57:10 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99c0d7490554f43ed1b14d315a39be5f4c5e3fc0
Cr-Commit-Position: refs/heads/master@{#436714}

Powered by Google App Engine
This is Rietveld 408576698