Revert of cc: SwapAck throttle Swap without throttling MainFrames

Revert of cc: SwapAck throttle Swap without throttling MainFrames (https://codereview.chromium.org/222023010/)

Reason for revert:
[Sheriff] Speculative revert for breaking win7 dbg:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26034

Will reland if it didn't help.

Original issue's description:
> cc: SwapAck throttle Swap without throttling MainFrames
> 
> This should improve main thread throughput in cases
> where we are deferring the BeginMainFrame, but don't
> really need to because the swap ack will come back
> before the impl thread needs to draw anyway.
> 
> BUG=311213
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266685

NOTREECHECKS=true
NOTRY=true
BUG=311213
TBR=Sami, danakj, brianderson

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266757

[Michael Achenbach, 2014-04-29 07:02:03]

Created Revert of cc: SwapAck throttle Swap without throttling MainFrames

[commit-bot: I haz the power, 2014-04-29 07:02:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/machenbach@chromium.org/255033004/1

[commit-bot: I haz the power, 2014-04-29 07:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:02:46]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Michael Achenbach, 2014-04-29 07:03:41]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:04:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/machenbach@chromium.org/255033004/1

[commit-bot: I haz the power, 2014-04-29 07:04:52]

Change committed as 266757

[Michael Achenbach, 2014-04-29 10:42:42]

What grinds my gears: I did a bisect on the waterfall because of the win7 issue
and in 266683, the error was already present
(http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...).
But reverting this CL seems to have solved all issues. Maybe there is some
interaction with another CL.

Another issue that is clearly related to 266685:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

Bisected locally (needs around 4 retries due to flakiness):
out/Debug/content_browsertests --brave-new-test-launcher
--gtest_also_run_disabled_tests
--gtest_filter=WebRtcBrowserTests/WebRtcBrowserTest.EstablishAudioVideoCallAndVerifyMutingWorks/0

Some tests also got very slow after 266685.

Please test thoroughly before relanding as this introduced flakes that were
rather hard to repro.

[chromium-reviews, 2014-04-29 15:38:03]

Thanks for figuring that out Michael. It's interesting that you point out
the error was already present, but that my patch made it worse.  The patch
does change timing in Chrome, but shouldn't put Chrome in state that
couldn't exist before. It's likely that an existing bug is being tickled
more often.

I will make sure I can reproduce the bug and fix it before I re-land.



On Tue, Apr 29, 2014 at 3:42 AM, <machenbach@chromium.org> wrote:

> What grinds my gears: I did a bisect on the waterfall because of the win7
> issue
> and in 266683, the error was already present
> (http://build.chromium.org/p/chromium.win/builders/Win7%
> 20Tests%20%28dbg%29%284%29/builds/26038).
> But reverting this CL seems to have solved all issues. Maybe there is some
> interaction with another CL.
>
> Another issue that is clearly related to 266685:
> http://build.chromium.org/p/chromium.linux/builders/Linux%
> 20Tests%20%28dbg%29%281%29/builds/31734
>
> Bisected locally (needs around 4 retries due to flakiness):
> out/Debug/content_browsertests --brave-new-test-launcher
> --gtest_also_run_disabled_tests
> --gtest_filter=WebRtcBrowserTests/WebRtcBrowserTest.
> EstablishAudioVideoCallAndVerifyMutingWorks/0
>
> Some tests also got very slow after 266685.
>
> Please test thoroughly before relanding as this introduced flakes that were
> rather hard to repro.
>
> https://codereview.chromium.org/255033004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.