Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: ash/shell.cc

Issue 255033003: Convert sticky keys to a chromeos::EventRewriter phase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x354034-er
Patch Set: Convert sticky keys to a chromeos::EventRewriter phase. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_controller.h » ('j') | ash/sticky_keys/sticky_keys_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index c8d5da4888a006caf6dad660bcffd02a7cb3672a..3d10a1d77c9cebc3208a9bdb65b0ee257a539285 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -901,13 +901,6 @@ void Shell::Init(const ShellInitParams& init_params) {
// The order in which event filters are added is significant.
-#if defined(OS_CHROMEOS)
- // The StickyKeysController also rewrites events and must be added
- // before observers, but after the EventRewriterEventFilter.
- sticky_keys_controller_.reset(new StickyKeysController);
- AddPreTargetHandler(sticky_keys_controller_.get());
-#endif
-
// wm::UserActivityDetector passes events to observers, so let them get
// rewritten first.
user_activity_detector_.reset(new ::wm::UserActivityDetector);
@@ -942,6 +935,10 @@ void Shell::Init(const ShellInitParams& init_params) {
keyboard::InitializeKeyboard();
#endif
+#if defined(OS_CHROMEOS)
+ sticky_keys_controller_.reset(new StickyKeysController);
+#endif
+
lock_state_controller_.reset(new LockStateController);
power_button_controller_.reset(new PowerButtonController(
lock_state_controller_.get()));
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_controller.h » ('j') | ash/sticky_keys/sticky_keys_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698