Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: ash/shell.cc

Issue 255033003: Convert sticky keys to a chromeos::EventRewriter phase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x354034-er
Patch Set: address review comments from sadrul Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "ash/accelerators/accelerator_controller.h" 10 #include "ash/accelerators/accelerator_controller.h"
(...skipping 871 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 882
883 #if defined(OS_CHROMEOS) && defined(USE_X11) 883 #if defined(OS_CHROMEOS) && defined(USE_X11)
884 magnifier_key_scroll_handler_ = MagnifierKeyScroller::CreateHandler().Pass(); 884 magnifier_key_scroll_handler_ = MagnifierKeyScroller::CreateHandler().Pass();
885 AddPreTargetHandler(magnifier_key_scroll_handler_.get()); 885 AddPreTargetHandler(magnifier_key_scroll_handler_.get());
886 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler().Pass(); 886 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler().Pass();
887 AddPreTargetHandler(speech_feedback_handler_.get()); 887 AddPreTargetHandler(speech_feedback_handler_.get());
888 #endif 888 #endif
889 889
890 // The order in which event filters are added is significant. 890 // The order in which event filters are added is significant.
891 891
892 #if defined(OS_CHROMEOS)
893 // The StickyKeysController also rewrites events and must be added
894 // before observers, but after the EventRewriterEventFilter.
895 sticky_keys_controller_.reset(new StickyKeysController);
896 AddPreTargetHandler(sticky_keys_controller_.get());
897 #endif
898
899 // wm::UserActivityDetector passes events to observers, so let them get 892 // wm::UserActivityDetector passes events to observers, so let them get
900 // rewritten first. 893 // rewritten first.
901 user_activity_detector_.reset(new ::wm::UserActivityDetector); 894 user_activity_detector_.reset(new ::wm::UserActivityDetector);
902 AddPreTargetHandler(user_activity_detector_.get()); 895 AddPreTargetHandler(user_activity_detector_.get());
903 896
904 overlay_filter_.reset(new OverlayEventFilter); 897 overlay_filter_.reset(new OverlayEventFilter);
905 AddPreTargetHandler(overlay_filter_.get()); 898 AddPreTargetHandler(overlay_filter_.get());
906 AddShellObserver(overlay_filter_.get()); 899 AddShellObserver(overlay_filter_.get());
907 900
908 input_method_filter_.reset(new ::wm::InputMethodEventFilter( 901 input_method_filter_.reset(new ::wm::InputMethodEventFilter(
(...skipping 14 matching lines...) Expand all
923 916
924 keyboard_metrics_filter_.reset(new KeyboardUMAEventFilter); 917 keyboard_metrics_filter_.reset(new KeyboardUMAEventFilter);
925 AddPreTargetHandler(keyboard_metrics_filter_.get()); 918 AddPreTargetHandler(keyboard_metrics_filter_.get());
926 919
927 // The keyboard system must be initialized before the RootWindowController is 920 // The keyboard system must be initialized before the RootWindowController is
928 // created. 921 // created.
929 #if defined(OS_CHROMEOS) 922 #if defined(OS_CHROMEOS)
930 keyboard::InitializeKeyboard(); 923 keyboard::InitializeKeyboard();
931 #endif 924 #endif
932 925
926 #if defined(OS_CHROMEOS)
927 sticky_keys_controller_.reset(new StickyKeysController);
928 #endif
929
933 lock_state_controller_.reset(new LockStateController); 930 lock_state_controller_.reset(new LockStateController);
934 power_button_controller_.reset(new PowerButtonController( 931 power_button_controller_.reset(new PowerButtonController(
935 lock_state_controller_.get())); 932 lock_state_controller_.get()));
936 #if defined(OS_CHROMEOS) 933 #if defined(OS_CHROMEOS)
937 // Pass the initial display state to PowerButtonController. 934 // Pass the initial display state to PowerButtonController.
938 power_button_controller_->OnDisplayModeChanged( 935 power_button_controller_->OnDisplayModeChanged(
939 display_configurator_->cached_displays()); 936 display_configurator_->cached_displays());
940 #endif 937 #endif
941 AddShellObserver(lock_state_controller_.get()); 938 AddShellObserver(lock_state_controller_.get());
942 939
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 //////////////////////////////////////////////////////////////////////////////// 1136 ////////////////////////////////////////////////////////////////////////////////
1140 // Shell, aura::client::ActivationChangeObserver implementation: 1137 // Shell, aura::client::ActivationChangeObserver implementation:
1141 1138
1142 void Shell::OnWindowActivated(aura::Window* gained_active, 1139 void Shell::OnWindowActivated(aura::Window* gained_active,
1143 aura::Window* lost_active) { 1140 aura::Window* lost_active) {
1144 if (gained_active) 1141 if (gained_active)
1145 target_root_window_ = gained_active->GetRootWindow(); 1142 target_root_window_ = gained_active->GetRootWindow();
1146 } 1143 }
1147 1144
1148 } // namespace ash 1145 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_controller.h » ('j') | ash/sticky_keys/sticky_keys_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698