Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Side by Side Diff: ash/shell.cc

Issue 255033003: Convert sticky keys to a chromeos::EventRewriter phase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x354034-er
Patch Set: Convert sticky keys to a chromeos::EventRewriter phase. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "ash/accelerators/accelerator_controller.h" 10 #include "ash/accelerators/accelerator_controller.h"
(...skipping 883 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 894
895 #if defined(OS_CHROMEOS) && defined(USE_X11) 895 #if defined(OS_CHROMEOS) && defined(USE_X11)
896 magnifier_key_scroll_handler_ = MagnifierKeyScroller::CreateHandler().Pass(); 896 magnifier_key_scroll_handler_ = MagnifierKeyScroller::CreateHandler().Pass();
897 AddPreTargetHandler(magnifier_key_scroll_handler_.get()); 897 AddPreTargetHandler(magnifier_key_scroll_handler_.get());
898 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler().Pass(); 898 speech_feedback_handler_ = SpokenFeedbackToggler::CreateHandler().Pass();
899 AddPreTargetHandler(speech_feedback_handler_.get()); 899 AddPreTargetHandler(speech_feedback_handler_.get());
900 #endif 900 #endif
901 901
902 // The order in which event filters are added is significant. 902 // The order in which event filters are added is significant.
903 903
904 #if defined(OS_CHROMEOS)
905 // The StickyKeysController also rewrites events and must be added
906 // before observers, but after the EventRewriterEventFilter.
907 sticky_keys_controller_.reset(new StickyKeysController);
908 AddPreTargetHandler(sticky_keys_controller_.get());
909 #endif
910
911 // wm::UserActivityDetector passes events to observers, so let them get 904 // wm::UserActivityDetector passes events to observers, so let them get
912 // rewritten first. 905 // rewritten first.
913 user_activity_detector_.reset(new ::wm::UserActivityDetector); 906 user_activity_detector_.reset(new ::wm::UserActivityDetector);
914 AddPreTargetHandler(user_activity_detector_.get()); 907 AddPreTargetHandler(user_activity_detector_.get());
915 908
916 overlay_filter_.reset(new OverlayEventFilter); 909 overlay_filter_.reset(new OverlayEventFilter);
917 AddPreTargetHandler(overlay_filter_.get()); 910 AddPreTargetHandler(overlay_filter_.get());
918 AddShellObserver(overlay_filter_.get()); 911 AddShellObserver(overlay_filter_.get());
919 912
920 input_method_filter_.reset(new ::wm::InputMethodEventFilter( 913 input_method_filter_.reset(new ::wm::InputMethodEventFilter(
(...skipping 14 matching lines...) Expand all
935 928
936 keyboard_metrics_filter_.reset(new KeyboardUMAEventFilter); 929 keyboard_metrics_filter_.reset(new KeyboardUMAEventFilter);
937 AddPreTargetHandler(keyboard_metrics_filter_.get()); 930 AddPreTargetHandler(keyboard_metrics_filter_.get());
938 931
939 // The keyboard system must be initialized before the RootWindowController is 932 // The keyboard system must be initialized before the RootWindowController is
940 // created. 933 // created.
941 #if defined(OS_CHROMEOS) 934 #if defined(OS_CHROMEOS)
942 keyboard::InitializeKeyboard(); 935 keyboard::InitializeKeyboard();
943 #endif 936 #endif
944 937
938 #if defined(OS_CHROMEOS)
939 sticky_keys_controller_.reset(new StickyKeysController);
940 #endif
941
945 lock_state_controller_.reset(new LockStateController); 942 lock_state_controller_.reset(new LockStateController);
946 power_button_controller_.reset(new PowerButtonController( 943 power_button_controller_.reset(new PowerButtonController(
947 lock_state_controller_.get())); 944 lock_state_controller_.get()));
948 #if defined(OS_CHROMEOS) 945 #if defined(OS_CHROMEOS)
949 // Pass the initial display state to PowerButtonController. 946 // Pass the initial display state to PowerButtonController.
950 power_button_controller_->OnDisplayModeChanged( 947 power_button_controller_->OnDisplayModeChanged(
951 display_configurator_->cached_displays()); 948 display_configurator_->cached_displays());
952 #endif 949 #endif
953 AddShellObserver(lock_state_controller_.get()); 950 AddShellObserver(lock_state_controller_.get());
954 951
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
1151 //////////////////////////////////////////////////////////////////////////////// 1148 ////////////////////////////////////////////////////////////////////////////////
1152 // Shell, aura::client::ActivationChangeObserver implementation: 1149 // Shell, aura::client::ActivationChangeObserver implementation:
1153 1150
1154 void Shell::OnWindowActivated(aura::Window* gained_active, 1151 void Shell::OnWindowActivated(aura::Window* gained_active,
1155 aura::Window* lost_active) { 1152 aura::Window* lost_active) {
1156 if (gained_active) 1153 if (gained_active)
1157 target_root_window_ = gained_active->GetRootWindow(); 1154 target_root_window_ = gained_active->GetRootWindow();
1158 } 1155 }
1159 1156
1160 } // namespace ash 1157 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_controller.h » ('j') | ash/sticky_keys/sticky_keys_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698