Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2550323004: views: support Harmony title insets (Closed)

Created:
4 years ago by Elly Fong-Jones
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: support Harmony title insets This change adds a method to ViewsDelegate called GetDialogFrameViewInsets, which returns the insets that should be applied around a dialog's FrameView title. BUG=610428 Committed: https://crrev.com/9bf7c586548ab8b4616553b9fbe1d75f0f96b652 Cr-Commit-Position: refs/heads/master@{#437010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/views_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elly Fong-Jones
sky: ptal? :)
4 years ago (2016-12-07 15:37:47 UTC) #3
sky
LGTM
4 years ago (2016-12-07 17:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550323004/1
4 years ago (2016-12-07 17:03:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:22:34 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 18:26:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bf7c586548ab8b4616553b9fbe1d75f0f96b652
Cr-Commit-Position: refs/heads/master@{#437010}

Powered by Google App Engine
This is Rietveld 408576698