Insert default arguments for static calls and constructor calls.

Insert default arguments for static calls and constructor calls.

https://github.com/dart-lang/sdk/issues/27394

R=efortuna@google.com, johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9f373eb5beb314385db77cd117a44b82abd908b6

[sra1, 2016-12-06 04:11:57]

Description was changed from

==========
Insert default arguments for static calls and constructor calls.
==========

to

==========
Insert default arguments for static calls and constructor calls.

https://github.com/dart-lang/sdk/issues/27394
==========

[sra1, 2016-12-06 04:11:58]

sra@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com, sigmund@google.com

[sra1, 2016-12-06 04:12:30]

Patchset #1 (id:1) has been deleted

[sra1, 2016-12-06 04:12:36]

Patchset #2 (id:40001) has been deleted

[sra1, 2016-12-06 04:12:41]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-12-06 04:14:28]

Patchset #1 (id:60001) has been deleted

[sra1, 2016-12-06 04:22:34]

I decided to look up the ConstantExpressions computed during resolution.
Longer term I would like to directly evaluate the constants, i.e. use the kernel
ir.Expression as a ConstantExpression.

johnni - is there a problem with the above, or did ConstantExpressions just help
with semantically unresolved Ast?

[Johnni Winther, 2016-12-06 08:36:37]

LGTM

The approach for constants is good. I will at some point change
ConstantExpression and ConstantValue to work with Entity such that we can
generate these directly from kernel.

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1316: List<HInstruction> inputs =
_visitList(invocation.arguments.positional);
I'd prefer calling [_visitArgumentsForStaticTarget] here, or add new helper
methods for simple arguments that asserts that there are no optional arguments.

[Siggi Cherem (dart-lang), 2016-12-06 18:04:15]

lgtm

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1085: /// dynamic target (member
function).
now might be a good opportunity to document why this and static targets look
different. In particular, we can say that for dynamic targets we generate stubs
that will fill-in default values for non-specified optional arguments, but that
with static targets we just fill them in directly at the call site.

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1150: // TODO(sra): Evaluate
constant in ir.Node domain.
when we do - I'd like to request from kernel-ir some invariants. For example,
that there are no invalid nodes and we can use a very simple visitor to do the
evaluation.

[Emily Fortuna, 2016-12-06 18:25:45]

lgtm

[sra1, 2016-12-06 18:27:37]

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1085: /// dynamic target (member
function).
On 2016/12/06 18:04:15, Siggi Cherem (dart-lang) wrote:
> now might be a good opportunity to document why this and static targets look
> different. In particular, we can say that for dynamic targets we generate
stubs
> that will fill-in default values for non-specified optional arguments, but
that
> with static targets we just fill them in directly at the call site.

Done.

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1150: // TODO(sra): Evaluate
constant in ir.Node domain.
On 2016/12/06 18:04:15, Siggi Cherem (dart-lang) wrote:
> when we do - I'd like to request from kernel-ir some invariants. For example,
> that there are no invalid nodes and we can use a very simple visitor to do the
> evaluation.

Acknowledged.

https://codereview.chromium.org/2550323002/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1316: List<HInstruction> inputs =
_visitList(invocation.arguments.positional);
On 2016/12/06 08:36:37, Johnni Winther wrote:
> I'd prefer calling [_visitArgumentsForStaticTarget] here, or add new helper
> methods for simple arguments that asserts that there are no optional
arguments.

The _unexpectedForeignArguments call ensures there are no named optional
arguments.
I renamed _visitList to _visitPositionalArguments and passed the ir.Arguments

[sra1, 2016-12-06 19:15:09]

Description was changed from

==========
Insert default arguments for static calls and constructor calls.

https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Insert default arguments for static calls and constructor calls.

https://github.com/dart-lang/sdk/issues/27394

R=efortuna@google.com, johnniwinther@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9f373eb5beb314385db77cd117a44b82abd908b6
==========

[sra1, 2016-12-06 19:15:10]

Committed patchset #1 (id:80001) manually as
9f373eb5beb314385db77cd117a44b82abd908b6 (presubmit successful).