Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2550293003: Don't cache invalid serialized Physical Web URLs (Closed)

Created:
4 years ago by cco3
Modified:
4 years ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't cache invalid serialized Physical Web URLs Currently, when the UrlManager starts, it deserializes our stored UrlInfos and attempts to gracefully fail if one cannot be deserialized. However, the URL the info corresponds to may be contained in some still existent cache. This change makes sure that only URLs that are properly deserialized are stored. BUG=671400 Committed: https://crrev.com/06617f6e14805e099200670ea964025a66f316b6 Cr-Commit-Position: refs/heads/master@{#436825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cco3
4 years ago (2016-12-05 23:59:00 UTC) #2
mattreynolds
lgtm
4 years ago (2016-12-06 01:35:33 UTC) #3
cco3
4 years ago (2016-12-06 18:33:09 UTC) #5
nyquist
lgtm
4 years ago (2016-12-07 00:57:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550293003/1
4 years ago (2016-12-07 01:04:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 01:37:23 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 01:42:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06617f6e14805e099200670ea964025a66f316b6
Cr-Commit-Position: refs/heads/master@{#436825}

Powered by Google App Engine
This is Rietveld 408576698