Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2550283002: Fix incorrect type in override of CompilationError.span. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incorrect type in override of CompilationError.span. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/eb9f3ba93124a53224779cba5a139e13c60a9ed7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/front_end/lib/kernel_generator.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
4 years ago (2016-12-05 22:01:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm, thanks, I ran dart2analyzer tests on the package, but didn't think that it needs ...
4 years ago (2016-12-05 22:19:05 UTC) #3
Paul Berry
On 2016/12/05 22:19:05, Siggi Cherem (dart-lang) wrote: > lgtm, thanks, I ran dart2analyzer tests on ...
4 years ago (2016-12-05 22:35:10 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as eb9f3ba93124a53224779cba5a139e13c60a9ed7 (presubmit successful).
4 years ago (2016-12-05 22:36:01 UTC) #6
Paul Berry
4 years ago (2016-12-06 20:41:42 UTC) #7
Message was sent while issue was closed.
On 2016/12/05 22:35:10, Paul Berry wrote:
> On 2016/12/05 22:19:05, Siggi Cherem (dart-lang) wrote:
> > lgtm, thanks, I ran dart2analyzer tests on the package, but didn't think
that
> it
> > needs to be run in strong mode.
> > 
> > Is there a way to do that in test.py and the bots or not yet?
> 
> Good question.  I don't know why this wasn't caught by the dart2analyzer
tests. 
> I'll investigate.

I looked into it and I don't see an easy fix.  I've filed
https://github.com/dart-lang/sdk/issues/28013 to track the issue.

Powered by Google App Engine
This is Rietveld 408576698