Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2550273004: Make Internals::mainThreadScrollingReasons work with spv2. (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Internals::mainThreadScrollingReasons work with spv2. This patch fixes the main thread scrolling reasons when slimming paint v2 is enabled by adding a non-ScrollingCoordinator codepath. Unlike ScrollingCoordinator, slimming paint v2's main thread scrolling reasons are maintained per-scrolling LayoutObjects, so we have to walk the entire layout tree to calculate the page's main thread scrolling reasons. BUG=671838 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
pdr.
Description was changed from ========== Make Internals::mainThreadScrollingReasons work with spv2. This patch fixes the main ...
4 years ago (2016-12-07 01:53:19 UTC) #1
pdr.
Description was changed from ========== Make Internals::mainThreadScrollingReasons work with spv2. This patch fixes the main ...
4 years ago (2016-12-07 01:53:30 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
4 years ago (2016-12-07 01:53:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550273004/1
4 years ago (2016-12-07 01:53:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-07 03:55:05 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-07 03:55:06 UTC) #6
Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

Powered by Google App Engine
This is Rietveld 408576698