Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 255025: Set new homepage preferences only if there is no existing value. (Closed)

Created:
11 years, 2 months ago by kuchhal
Modified:
9 years, 7 months ago
Reviewers:
Glenn Wilson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Set new homepage preferences only if there is no existing value. BUG=23402 TEST=On a clean install, make sure Chrome has Homepage button enabled. Use master_preferences to disable homapage button and make sure it works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chrome/browser/browser.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kuchhal
11 years, 2 months ago (2009-09-30 16:30:37 UTC) #1
Glenn Wilson
11 years, 2 months ago (2009-09-30 16:42:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698