Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: android_webview/browser/browser_view_renderer_client.h

Issue 255023004: Add synchronous requestDrawGL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: roll aosp Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer_client.h
diff --git a/android_webview/browser/browser_view_renderer_client.h b/android_webview/browser/browser_view_renderer_client.h
index 382ce0d8f8f330d86ba50d314ddc12be9907fd48..7359cd3df2cf5f41dc1c2381bb04ce429287428d 100644
--- a/android_webview/browser/browser_view_renderer_client.h
+++ b/android_webview/browser/browser_view_renderer_client.h
@@ -15,9 +15,11 @@ namespace android_webview {
class BrowserViewRendererClient {
public:
// Request DrawGL be called. Passing null |canvas| implies the request
- // will be of AwDrawGLInfo::kModeProcess type. The callback
- // may never be made, and the mode may be promoted to kModeDraw.
- virtual bool RequestDrawGL(jobject canvas) = 0;
+ // will be of AwDrawGLInfo::kModeProcess type. |wait_for_completion|
+ // will cause the call to block until DrawGL has happened; it does not
+ // together with |canvas|. The callback may never be made, and the mode may
hush (inactive) 2014/05/01 00:35:54 do you mean |wait_for_completion| should not be tr
boliu 2014/05/01 00:46:36 Yes. Fixed up comment.
+ // be promoted to kModeDraw.
+ virtual bool RequestDrawGL(jobject canvas, bool wait_for_completion) = 0;
// Called when a new Picture is available. Needs to be enabled
// via the EnableOnNewPicture method.

Powered by Google App Engine
This is Rietveld 408576698