Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4356)

Unified Diff: build/common.gypi

Issue 255023003: Linux: Switch 32-bit official builds to use the bundled 64-bit linker. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, no tabs Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/binutils/download.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 266613)
+++ build/common.gypi (working copy)
@@ -729,8 +729,8 @@
# linux_use_bundled_gold: whether to use the gold linker binary checked
# into third_party/binutils. Force this off via GYP_DEFINES when you
# are using a custom toolchain and need to control -B in ldflags.
- # Gold is not used for 32-bit linux builds as it runs out of address
- # space.
+ # Do not use 32-bit gold on 32-bit hosts as it runs out address space
+ # for component=static_library builds.
['OS=="linux" and (target_arch=="x64" or target_arch=="arm")', {
'linux_use_bundled_gold%': 1,
}, {
@@ -1445,6 +1445,16 @@
# Omit unwind support in official release builds to save space. We
# can use breakpad for these builds.
'release_unwind_tables%': 0,
+
+ 'conditions': [
+ # For official builds, use a 64-bit linker to avoid running out
+ # of address space. The buildbots should have a 64-bit kernel
+ # and a 64-bit libc installed.
+ ['host_arch=="ia32" and target_arch=="ia32"', {
+ 'linux_use_bundled_gold%': '1',
+ 'binutils_dir%': 'third_party/binutils/Linux_x64/Release/bin',
+ }],
+ ],
}],
],
}], # os_posix==1 and OS!="mac" and OS!="ios"
@@ -3795,16 +3805,14 @@
['linux_dump_symbols==1', {
'cflags': [ '-g' ],
'conditions': [
- # TODO(thestig) We should not need to specify chromeos==0 here,
- # but somehow ChromeOS uses gold despite linux_use_bundled_gold==0.
- # http://crbug.com./360082
- ['linux_use_bundled_gold==0 and chromeos==0 and OS!="android"', {
+ ['OS=="linux" and host_arch=="ia32" and linux_use_bundled_gold==0', {
'target_conditions': [
['_toolset=="target"', {
'ldflags': [
- # Workarounds for linker OOM.
+ # Attempt to use less memory to prevent the linker from
+ # running out of address space. Considering installing a
+ # 64-bit kernel and switching to a 64-bit linker.
'-Wl,--no-keep-memory',
- '-Wl,--reduce-memory-overheads',
],
}],
],
« no previous file with comments | « no previous file | third_party/binutils/download.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698