chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js - Issue 2550223002: Support basic stereo pan positioning for earcons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

Issue 2550223002: Support basic stereo pan positioning for earcons (Closed)

Patch Set: Fix test. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/earcons.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js b/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

index c3b1e8f7c383629c63350b23dd685de8a5912f3e..f08997986a4fc8a52d313d84ff2d7e6448546f81 100644

--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

@@ -49,7 +49,7 @@ cvox.ClassicEarcons.prototype.getBaseUrl = function() {

/**

* @override

-cvox.ClassicEarcons.prototype.playEarcon = function(earcon) {

+cvox.ClassicEarcons.prototype.playEarcon = function(earcon, opt_location) {

goog.base(this, 'playEarcon', earcon);

if (!cvox.AbstractEarcons.enabled) {

return;