chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js - Issue 2550223002: Support basic stereo pan positioning for earcons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

Issue 2550223002: Support basic stereo pan positioning for earcons (Closed)

Patch Set: Fix test. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/earcon_engine.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

index 9d2a6b4b25fc13bdea8fb336afe8d4e68072ba32..67cd71fea88c2316d8bb2366ceaa8e4ade9c3391 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

@@ -43,12 +43,18 @@ NextEarcons.prototype = {

/**

* @override

- playEarcon: function(earcon) {

+ playEarcon: function(earcon, opt_location) {

if (!cvox.AbstractEarcons.enabled) {

return;

}

console.log('Earcon ' + earcon);

+ if (ChromeVoxState.instance.currentRange &&

+ ChromeVoxState.instance.currentRange.isValid()) {

+ var node = ChromeVoxState.instance.currentRange.start.node;

+ var rect = opt_location || node.location;

+ var container = node.root.location;

+ this.engine_.setPositionForRect(rect, container);

+ }

switch (earcon) {

case cvox.Earcon.ALERT_MODAL:

case cvox.Earcon.ALERT_NONMODAL: