[DevTools] Fix Cookie Sort

third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

 /*
  * Copyright (C) 2009 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 193 matching lines @@
     return totalSize;
   }
 
   /**
    * @param {!Array.<!SDK.Cookie>} cookies
    */
   _sortCookies(cookies) {
     var sortDirection = this._dataGrid.isSortOrderAscending() ? 1 : -1;
 
     /**
+     * @param {!SDK.Cookie} cookie
+     * @param {string} property
+     * @return {string} Value of the property or `name` if no such property exists

[dgozman, 2016/12/06 01:35:00]

We don't describe the return value, just mention the result type.
The reason for that is written comments get outdated quickly, while
compilation-enforced types do not.

+     */
+    function getValue(cookie, property) {
+      return typeof cookie[property] === 'function' ? String(cookie[property]()) : String(cookie.name());
+    }
+
+    /**
      * @param {string} property
      * @param {!SDK.Cookie} cookie1
      * @param {!SDK.Cookie} cookie2
      */
     function compareTo(property, cookie1, cookie2) {
-      return sortDirection *
-          (String(cookie1[property] || cookie1['name'])).compareTo(String(cookie2[property] || cookie2['name']));
+      return sortDirection * getValue(cookie1, property).compareTo(getValue(cookie2, property));
     }
 
     /**
      * @param {!SDK.Cookie} cookie1
      * @param {!SDK.Cookie} cookie2
      */
     function numberCompare(cookie1, cookie2) {
       return sortDirection * (cookie1.size() - cookie2.size());
     }
 
@@ skipping 67 matching lines @@
       this._nextSelectedCookie = neighbour.cookie;
     cookie.remove();
     this._refresh();
   }
 
   _refresh() {
     if (this._refreshCallback)
       this._refreshCallback();
   }
 };