Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2550203003: Add command buffer support for EXT_sRGB_write_control (Closed)

Created:
4 years ago by ccameron
Modified:
4 years ago
Reviewers:
zmo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add command buffer support for EXT_sRGB_write_control This state is not set in the service side at glEnable/glDisable time. Instead, it is set during framebuffer validation, to accommodate driver bug workarounds on desktop. Re-land of patch previously submitted at crrev.com/435631 TBR=zmo BUG=655247 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/63b3546297d36805f698468ce6f9df2e77f1e6b6 Cr-Commit-Position: refs/heads/master@{#436555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -11 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state_autogen.h View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 4 chunks +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +22 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550203003/1
4 years ago (2016-12-06 08:55:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 09:47:44 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-06 09:50:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63b3546297d36805f698468ce6f9df2e77f1e6b6
Cr-Commit-Position: refs/heads/master@{#436555}

Powered by Google App Engine
This is Rietveld 408576698