|
|
Chromium Code Reviews|
Created:
4 years ago by aleksandar.stojiljkovic Modified:
4 years ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/4aad17fb748c0e707ad71b6b054aa9d37120e44e
Cr-Commit-Position: refs/heads/master@{#436425}
Patch Set 1 #Patch Set 2 : Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina #Messages
Total messages: 16 (10 generated)
Description was changed from ========== DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina BUG=671206 ========== to ========== DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina BUG=671206 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Patchset #1 (id:1) has been deleted
Description was changed from
==========
DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
to
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number. Happens rarely for flipY.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
Description was changed from
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number. Happens rarely for flipY.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
to
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number. This wasn't noticed before as it
happens only when the time between fake capture start and getting the first
frame is > 2.5s (see kGradientFrequency = 1.f / 5 in
fake_video_capture_device.cc).
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
Description was changed from
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number. This wasn't noticed before as it
happens only when the time between fake capture start and getting the first
frame is > 2.5s (see kGradientFrequency = 1.f / 5 in
fake_video_capture_device.cc).
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
to
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
aleksandar.stojiljkovic@intel.com changed reviewers: + kbr@chromium.org, phoglund@chromium.org
kbr@, phoglund@, PTAL. Thanks. This is related to modulo of negative number. It happens only when the time between fake capture start and getting the first frame is > 2.5s (see kGradientFrequency = 1.f / 5 in fake_video_capture_device.cc).
The CQ bit was checked by kbr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480971949191100,
"parent_rev": "923cd9144e9d1c859729f575abbe45061abed380", "commit_rev":
"1e27f2189aeb4df6dc1beeb324106bba1f65f290"}
Message was sent while issue was closed.
Description was changed from
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
to
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========
to
==========
Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina
This is related to modulo of negative number.
BUG=671206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/4aad17fb748c0e707ad71b6b054aa9d37120e44e
Cr-Commit-Position: refs/heads/master@{#436425}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4aad17fb748c0e707ad71b6b054aa9d37120e44e Cr-Commit-Position: refs/heads/master@{#436425}
Message was sent while issue was closed.
lgtm |
