Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2550183003:
[ios] Adds unittests that were inadvertently not compiled or run. (Closed)
|
Created:
4 years ago by rohitrao (ping after 24h) Modified:
4 years ago CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ios] Adds unittests that were inadvertently not compiled or run.
BUG=671842
Committed: https://crrev.com/32931ecdb47da39fc0083da68d341807b09e52a8
Cr-Commit-Position: refs/heads/master@{#436931}
Patch Set 1 #Patch Set 2 : Rebased. #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rohitrao@chromium.org changed reviewers: + noyau@chromium.org
Turns out these tests weren't ever being compiled or run =(
sdefresne@chromium.org changed reviewers: + sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm:
While running git apply --index -p1;
error: patch failed:
ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm:36
error: ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm: patch does
not apply
Patch: ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
Index: ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
diff --git a/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
b/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
index
85cceb264b133750bbd5e8f0600fc788490a353c..422e6b01cee3feafd058e5fc5d20f7ffe78a4bf4
100644
--- a/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
+++ b/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
@@ -36,7 +36,7 @@ class FakeGaiaAuthFetcherIOSBridge : public
GaiaAuthFetcherIOSBridge {
}
return mock_web_view_;
}
- scoped_nsobject<id> mock_web_view_;
+ base::scoped_nsobject<id> mock_web_view_;
};
class MockGaiaConsumer : public GaiaAuthConsumer {
lgtm
Description was changed from ========== [ios] Adds unittests that were inadvertently not compiled or run. BUG=None ========== to ========== [ios] Adds unittests that were inadvertently not compiled or run. BUG=671842 ==========
The CQ bit was checked by rohitrao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2550183003/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481113655169800,
"parent_rev": "3ba70e0a81ce23f98dbf88f54d70ec1a78faa4a6", "commit_rev":
"1a36b17bee7cda17efe77b0607f4b3350a3daa89"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [ios] Adds unittests that were inadvertently not compiled or run. BUG=671842 ========== to ========== [ios] Adds unittests that were inadvertently not compiled or run. BUG=671842 Committed: https://crrev.com/32931ecdb47da39fc0083da68d341807b09e52a8 Cr-Commit-Position: refs/heads/master@{#436931} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/32931ecdb47da39fc0083da68d341807b09e52a8 Cr-Commit-Position: refs/heads/master@{#436931} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
