Disable the leak tracking of URLRequests....

Disable the leak tracking of URLRequests.

This doesn't fix anything, it just prevents asserting (and consequently crashing) when the leak is observed, restoring the earlier behavior.

There are already a couple of know leaks, so crashing during shutdown isn't real useful until the known issues are fixed.

BUG=18372, 23284
TBR=darin


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27586

[eroman, 2009-09-30 00:24:13]

committing TBR

[darin (slow to review), 2009-09-30 03:26:24]

LGTM

On Tue, Sep 29, 2009 at 5:24 PM, <eroman@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> committing TBR
>
> Description:
> Disable the leak tracking of URLRequests.
>
> This doesn't fix anything, it just prevents asserting (and consequently
> crashing) when the leak is observed, restoring the earlier behavior.
>
> There are already a couple of know leaks, so crashing during shutdown isn't
> real
> useful until the known issues are fixed.
>
> BUG=18372,23284
>
> TBR=darin
>
>
> Please review this at http://codereview.chromium.org/255017
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/leak_tracker.h
>  M     net/url_request/url_request.cc
>
>
> Index: net/url_request/url_request.cc
> ===================================================================
> --- net/url_request/url_request.cc      (revision 27566)
> +++ net/url_request/url_request.cc      (working copy)
> @@ -41,8 +41,9 @@
>  URLRequest::InstanceTracker::~InstanceTracker() {
>   base::LeakTracker<URLRequest>::CheckForLeaks();
>
> -  // Check in release mode as well, since we have the info.
> -  CHECK(0u == GetLiveRequests().size());
> +  // Only check in Debug mode, because this is triggered too often.
> +  // See http://crbug.com/21199, http://crbug.com/18372
> +  DCHECK_EQ(0u, GetLiveRequests().size());
>  }
>
>  // static
> Index: base/leak_tracker.h
> ===================================================================
> --- base/leak_tracker.h (revision 27566)
> +++ base/leak_tracker.h (working copy)
> @@ -5,16 +5,8 @@
>  #ifndef BASE_LEAK_TRACKER_H_
>  #define BASE_LEAK_TRACKER_H_
>
> -// Temporarily enable LeakTracker in all builds (both
> -// release and debug). This will have an impact on performance, but
> -// is intended to help track down a leak which reproduces on dev
> -// channel.
> -//
> -// TODO(eroman): Restore the old code which only enabled LeakTracker
> -// for debug builds.
> -//
> -// http://crbug.com/21199, http://crbug.com/18372
> -#ifndef ENABLE_LEAK_TRACKER
> +// Only enable leak tracking in debug builds.
> +#ifndef NDEBUG
>  #define ENABLE_LEAK_TRACKER
>  #endif
>
>
>
>