Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3357)

Unified Diff: chrome/browser/shell_integration_unittest.cc

Issue 255016: GTK: improve app mode .desktop file creation.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/common/chrome_plugin_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration_unittest.cc
===================================================================
--- chrome/browser/shell_integration_unittest.cc (revision 27632)
+++ chrome/browser/shell_integration_unittest.cc (working copy)
@@ -69,7 +69,7 @@
"Version=1.0\n"
"Encoding=UTF-8\n"
"Name=GMail\n"
- "Exec=/opt/google/chrome/google-chrome \"--app=http://gmail.com/\"\n"
+ "Exec=/opt/google/chrome/google-chrome --app=\"http://gmail.com/\"\n"
"Terminal=false\n"
"Icon=chrome-http__gmail.com\n"
"Type=Application\n"
@@ -88,7 +88,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=GMail\n"
- "Exec=/opt/google/chrome/google-chrome \"--app=http://gmail.com/\"\n"
+ "Exec=/opt/google/chrome/google-chrome --app=\"http://gmail.com/\"\n"
},
// Make sure i18n-ed comments are removed.
@@ -102,7 +102,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=GMail\n"
- "Exec=/opt/google/chrome/google-chrome \"--app=http://gmail.com/\"\n"
+ "Exec=/opt/google/chrome/google-chrome --app=\"http://gmail.com/\"\n"
},
// Make sure that empty icons are replaced by the chrome icon.
@@ -117,7 +117,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=GMail\n"
- "Exec=/opt/google/chrome/google-chrome \"--app=http://gmail.com/\"\n"
+ "Exec=/opt/google/chrome/google-chrome --app=\"http://gmail.com/\"\n"
"Icon=/opt/google/chrome/product_logo_48.png\n"
},
@@ -132,7 +132,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=http://evil.com/evil%20--join-the-b0tnet\n"
"Exec=/opt/google/chrome/google-chrome "
- "\"--app=http://evil.com/evil%%20--join-the-b0tnet\"\n"
+ "--app=\"http://evil.com/evil%%20--join-the-b0tnet\"\n"
},
{ "http://evil.com/evil; rm -rf /; \"; rm -rf $HOME >ownz0red",
"Innocent Title",
@@ -144,7 +144,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=Innocent Title\n"
"Exec=/opt/google/chrome/google-chrome "
- "\"--app=http://evil.com/evil%%20rm%%20-rf%%20/%%20%%22%%20rm%%20"
+ "--app=\"http://evil.com/evil%%20rm%%20-rf%%20/%%20%%22%%20rm%%20"
"-rf%%20HOME%%20%%3Eownz0red\"\n"
},
{ "http://evil.com/evil | cat `echo ownz0red` >/dev/null\\",
@@ -157,7 +157,7 @@
"#!/usr/bin/env xdg-open\n"
"Name=Innocent Title\n"
"Exec=/opt/google/chrome/google-chrome "
- "\"--app=http://evil.com/evil%%20%%7C%%20cat%%20%%60echo%%20ownz0red"
+ "--app=\"http://evil.com/evil%%20%%7C%%20cat%%20%%60echo%%20ownz0red"
"%%60%%20%%3E/dev/null/\"\n"
},
};
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/common/chrome_plugin_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698