Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2550153002: Add jkrcal@ to components/ntp_snippets/OWNERS (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
Bernhard Bauer, jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add jkrcal@ to components/ntp_snippets/OWNERS While we're here, also sort the file alphabetically. Committed: https://crrev.com/84f9f731f843bf50c3039cf37e49f430929825da Cr-Commit-Position: refs/heads/master@{#436304}

Patch Set 1 #

Patch Set 2 : sections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M components/ntp_snippets/OWNERS View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Marc Treib
Let's get some more OWNERS! We could also order them into sections (e.g. "ios" -> ...
4 years ago (2016-12-05 13:13:26 UTC) #2
jkrcal
lgtm I think some comments (aka sections) would be great. Whenever I want to send ...
4 years ago (2016-12-05 13:48:45 UTC) #3
Bernhard Bauer
LGTM, suggestions sound good.
4 years ago (2016-12-05 15:46:28 UTC) #4
Marc Treib
Thanks! Added section comments.
4 years ago (2016-12-05 15:58:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550153002/20001
4 years ago (2016-12-05 15:59:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 16:08:19 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 16:12:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84f9f731f843bf50c3039cf37e49f430929825da
Cr-Commit-Position: refs/heads/master@{#436304}

Powered by Google App Engine
This is Rietveld 408576698