Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2550133002: Make cross-origin-preflight-get-response-type-blob fail when loading fails (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make cross-origin-preflight-get-response-type-blob fail when loading fails BUG=670562 R=tzik@chromium.org Committed: https://crrev.com/f28d5eeba2ca018e1c3995c0e9cb6a3f29b6f338 Cr-Commit-Position: refs/heads/master@{#436272}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html View 1 2 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
yhirano
4 years ago (2016-12-05 11:44:34 UTC) #3
tzik
https://codereview.chromium.org/2550133002/diff/1/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html File third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html (right): https://codereview.chromium.org/2550133002/diff/1/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html#newcode40 third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html:40: } Can we do it on "onloadend" handler?
4 years ago (2016-12-05 11:47:12 UTC) #4
yhirano
https://codereview.chromium.org/2550133002/diff/1/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html File third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html (right): https://codereview.chromium.org/2550133002/diff/1/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html#newcode40 third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-preflight-get-response-type-blob.html:40: } On 2016/12/05 11:47:12, tzik wrote: > Can we ...
4 years ago (2016-12-05 12:00:49 UTC) #9
tzik
lgtm
4 years ago (2016-12-05 12:06:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550133002/40001
4 years ago (2016-12-05 12:07:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 13:07:23 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-05 13:09:05 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f28d5eeba2ca018e1c3995c0e9cb6a3f29b6f338
Cr-Commit-Position: refs/heads/master@{#436272}

Powered by Google App Engine
This is Rietveld 408576698