Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2550123002: FontResource: use CHECKs to confirm if crrev.com/2551823002 fixes the issue (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FontResource: use CHECKs to confirm if crrev.com/2551823002 fixes the issue This patch is intended to confirm if the previous change can fix the issue that fires these CHECKs. Once this patch can survive for some days, I'd change them to DCHECKs. Otherwise, I'd revert this patch, and find another potential issues. Please feel free to revert this patch when you notice some crashes that are caused by this patch. BUG=670638 Committed: https://crrev.com/32c0cbefcb52226a0ec0765a2156d1c490377ec2 Cr-Commit-Position: refs/heads/master@{#436257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/loader/resource/FontResource.cpp View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-05 08:17:22 UTC) #3
yhirano
lgtm
4 years ago (2016-12-05 09:14:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550123002/1
4 years ago (2016-12-05 09:22:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:57:21 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-05 10:58:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32c0cbefcb52226a0ec0765a2156d1c490377ec2
Cr-Commit-Position: refs/heads/master@{#436257}

Powered by Google App Engine
This is Rietveld 408576698