Make ifdefs consistent in WebKit/Source/core/paint/ .

Make ifdefs consistent in WebKit/Source/core/paint/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4e0e9921800ee9af57aa927e67c082db3b1f9d44
Cr-Commit-Position: refs/heads/master@{#436630}

[Alexander Alekseev, 2016-12-06 10:02:59]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/core/paint/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
Make ifdefs consistent in WebKit/Source/core/paint/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Alexander Alekseev, 2016-12-06 10:04:38]

alemate@chromium.org changed reviewers:
+ schenney@chromium.org

[Alexander Alekseev, 2016-12-06 10:04:39]

assertSubtreeIsLaidOut() is guarded by DCHECK_IS_ON() macro, so this CL makes
checks consistent.

Please review.

[Alexander Alekseev, 2016-12-06 10:04:44]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 10:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 11:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:50:50]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2016-12-06 17:39:56]

The CQ bit was checked by schenney@chromium.org

[Stephen Chennney, 2016-12-06 17:39:56]

lgtm

[commit-bot: I haz the power, 2016-12-06 17:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 17:45:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481045996500270, "parent_rev":
"7159e32d75ec3ca4afeb63a0c15678befe75b05c", "commit_rev":
"a6006378fd752d8857cc0bca38fb7c8c35650f3d"}

[commit-bot: I haz the power, 2016-12-06 17:45:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 17:49:42]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/core/paint/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make ifdefs consistent in WebKit/Source/core/paint/ .

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/4e0e9921800ee9af57aa927e67c082db3b1f9d44
Cr-Commit-Position: refs/heads/master@{#436630}
==========

[commit-bot: I haz the power, 2016-12-06 17:49:43]

Patchset 1 (id:??) landed as
https://crrev.com/4e0e9921800ee9af57aa927e67c082db3b1f9d44
Cr-Commit-Position: refs/heads/master@{#436630}