Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2550113002: Send a subtree of same-process PageStates for back/forward child frames.

Created:
4 years ago by Charlie Reis
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send a subtree of same-process PageStates for back/forward child frames. This allows the renderer process to synchronously handle newly created child frames for session history navigations, unless the browser process has to be consulted for an out-of-process iframe. This is necessary in the case of about:blank (so that the parent can sychronously script the child) and an optimization in other cases (avoiding per-frame IPCs). BUG=671276 TEST=See bug for repro steps CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Update and fix most tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -103 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 2 chunks +19 lines, -13 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 3 chunks +29 lines, -27 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/navigation_params.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M content/common/navigation_params.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 4 chunks +52 lines, -27 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/navigation_controller/inject_into_blank_iframe_with_fragment.html View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
Charlie Reis
Description was changed from ========== Send a subtree of same-process PageStates for back/forward child frames. ...
4 years ago (2016-12-05 07:56:51 UTC) #1
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years ago (2016-12-05 07:56:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550113002/1
4 years ago (2016-12-05 07:57:02 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-05 08:28:55 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/347631)
4 years ago (2016-12-05 08:28:56 UTC) #5
Charlie Reis
Description was changed from ========== Send a subtree of same-process PageStates for back/forward child frames. ...
4 years ago (2016-12-05 18:41:32 UTC) #6
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years ago (2016-12-10 01:04:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550113002/40001
4 years ago (2016-12-10 01:05:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-10 01:56:25 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-10 01:56:26 UTC) #10
Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698