Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2550093011: Fix race condition with 'knownFiles'. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix race condition with 'knownFiles'. A temporary solution for now, not the most efficient. TBR R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/42aa2a6d25acb0727d9f62b2bf37a51d2a08c9bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-10 06:49:22 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 42aa2a6d25acb0727d9f62b2bf37a51d2a08c9bd (presubmit successful).
4 years ago (2016-12-10 06:49:36 UTC) #3
Brian Wilkerson
4 years ago (2016-12-10 15:44:18 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698