third_party/WebKit/Source/core/frame/csp/CSPSource.cpp - Issue 2550093005: Embedding-CSP: Fixing path matching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/csp/CSPSource.cpp

Issue 2550093005: Embedding-CSP: Fixing path matching (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/csp/CSPSource.cpp

diff --git a/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp b/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp

index bbde1965e3c178aae9988bbe2c567b2fee718169..92899f7608ee4b27888da2ff7e7578628a09eb2e 100644

--- a/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp

+++ b/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp

@@ -74,7 +74,7 @@ bool CSPSource::hostMatches(const String& host) const {

}

bool CSPSource::pathMatches(const String& urlPath) const {

- if (m_path.isEmpty())

+ if (m_path.isEmpty() || (m_path == "/" && urlPath.isEmpty()))

Mike West 2016/12/08 08:25:52 Can you add a test to `CSPSourceTest.cpp`?

return true;

String path = decodeURLEscapeSequences(urlPath);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp » ('j') | no next file with comments »