Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2550093004: [chromedriver] Disable WindowTest and ScreenshotTest on HEAD (Closed)

Created:
4 years ago by gmanikpure
Modified:
4 years ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Disable WindowTest and ScreenshotTest on HEAD BUG=chromedriver:1625 Committed: https://crrev.com/7c9068d21fd30ba3ef2b327b4f7e8386ca7e1bce Cr-Commit-Position: refs/heads/master@{#436683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/test/test_expectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
gmanikpure
4 years ago (2016-12-06 19:03:23 UTC) #2
samuong
lgtm, except you've got typo in the description ("Screenshotest")
4 years ago (2016-12-06 19:06:19 UTC) #3
gmanikpure
On 2016/12/06 19:06:19, samuong wrote: > lgtm, except you've got typo in the description ("Screenshotest") ...
4 years ago (2016-12-06 19:12:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550093004/1
4 years ago (2016-12-06 19:13:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 19:23:43 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 19:25:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c9068d21fd30ba3ef2b327b4f7e8386ca7e1bce
Cr-Commit-Position: refs/heads/master@{#436683}

Powered by Google App Engine
This is Rietveld 408576698