Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2550093002: [compiler] Print bailout reason for disabling FCG+CS. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Print bailout reason for disabling FCG+CS. When enforcing Ignition+TurboFan for a function literal during AstNumbering, make sure to print the bailout reason with --trace-opt to make it easier to figure out what caused the bailout. BUG=chromium:670691 R=jarin@chromium.org Committed: https://crrev.com/28514d210b66dbb1287c30115be0f5cca7fd37f3 Cr-Commit-Position: refs/heads/master@{#41472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/ast/ast-numbering.cc View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years ago (2016-12-05 05:37:54 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some debugging help. Please take a look. Thanks, Benedikt
4 years ago (2016-12-05 05:38:19 UTC) #4
Jarin
lgtm
4 years ago (2016-12-05 06:32:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550093002/1
4 years ago (2016-12-05 06:44:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 06:46:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 06:46:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28514d210b66dbb1287c30115be0f5cca7fd37f3
Cr-Commit-Position: refs/heads/master@{#41472}

Powered by Google App Engine
This is Rietveld 408576698