Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2550083002: Inline LayoutRect::enclosingIntRect (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline LayoutRect::enclosingIntRect Noticed this function was hot on blink_perf.paint's color-changes.html microbenchmark. With this patch, color-changes.html runs 2.7% faster (average -0.8ms) but that number should be taken with a grain of salt since it's near the standard deviation of the test. Manual profiling with and without the patch confirmed this function is no longer hot. Committed: https://crrev.com/af2c8d1e6a537c356b4cf931bb5aca1e5f09f119 Cr-Commit-Position: refs/heads/master@{#436323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/geometry/LayoutRect.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRect.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years ago (2016-12-05 06:22:41 UTC) #6
Xianzhu
lgtm
4 years ago (2016-12-05 16:44:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550083002/1
4 years ago (2016-12-05 16:44:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 16:49:03 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 16:51:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af2c8d1e6a537c356b4cf931bb5aca1e5f09f119
Cr-Commit-Position: refs/heads/master@{#436323}

Powered by Google App Engine
This is Rietveld 408576698