Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2550043002: [turbofan] Lower %_DebugIsActive intrinsic. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower %_DebugIsActive intrinsic. Add support to lower the %_DebugIsActive intrinsic during JSIntrinsicLowering instead of always going to the runtime for this. This addresses part of the Bluebird regression caused by sending let and const to TurboFan and Ignition. R=jarin@chromium.org Committed: https://crrev.com/c17ea79e81c7aadfccbab91cc85f0001433a0e16 Cr-Commit-Position: refs/heads/master@{#41468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years ago (2016-12-04 14:15:57 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an easy one to make promise.js easier for TurboFan. Please take a ...
4 years ago (2016-12-04 14:16:36 UTC) #4
Jarin
lgtm
4 years ago (2016-12-04 18:09:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550043002/1
4 years ago (2016-12-04 18:13:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 18:15:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-04 18:15:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c17ea79e81c7aadfccbab91cc85f0001433a0e16
Cr-Commit-Position: refs/heads/master@{#41468}

Powered by Google App Engine
This is Rietveld 408576698