Issue 255003002: Make CreateInitialObjects more concise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255003002: Make CreateInitialObjects more concise. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make CreateInitialObjects more concise. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21038

Patch Set 3 : addressed comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -171 lines)			Patch
M	src/factory.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/factory.cc	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/heap.h	View	1 2	4 chunks	+2 lines, -10 lines	0 comments	Download
M	src/heap.cc	View	1 2	10 chunks	+50 lines, -151 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nits: https://codereview.chromium.org/255003002/diff/20001/src/factory.h File src/factory.h (right): https://codereview.chromium.org/255003002/diff/20001/src/factory.h#newcode349 src/factory.h:349: Handle<JSObject> NewNeanderObject() { inline? https://codereview.chromium.org/255003002/diff/20001/src/heap.h File ...

6 years, 7 months ago (2014-04-28 15:56:08 UTC) #2

Yang

6 years, 7 months ago (2014-04-29 08:25:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21038 (presubmit successful).

Expand Messages | Collapse Messages

Issue 255003002: Make CreateInitialObjects more concise. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : addressed comment #

Messages