fix to show detached bookmark bar on NTP when "Show bookmarks bar" is on.

fix to show detached bookmark bar on NTP when "Show bookmarks bar" is on.

cause:
bookmark bar state in Browser wasn't updated when BrowserView::OnActiveTabChanged queries it to update the bookmark bar.

fix:
determine new bookmark bar state in Browser before calling BrowserView::OnActiveTabChanged.

BUG=299131
TEST=verify per bug rpt

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226454

[Peter Kasting, 2013-10-01 20:44:11]

Can this be tested?

LGTM otherwise

https://codereview.chromium.org/25500003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/25500003/diff/1/chrome/browser/ui/browser.cc#...
chrome/browser/ui/browser.cc:1056: // BOOKMARK_BAR_STATE_CHANGE_TAB_SWITCH
reason.
Nit: Can we just say:

Update the bookmark bar state, since the BrowserWindow may query it during
OnActiveTabChanged() below.

[kuan, 2013-10-02 00:15:37]

i've addressed the nit in patch set 2.  i've written an initial test but it
needs more work - i need it to fail w/out my change and also find a way to
disable animations.  peter has agreed that i can land this cl first, and work on
test after.

https://codereview.chromium.org/25500003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/25500003/diff/1/chrome/browser/ui/browser.cc#...
chrome/browser/ui/browser.cc:1056: // BOOKMARK_BAR_STATE_CHANGE_TAB_SWITCH
reason.
On 2013/10/01 20:44:11, Peter Kasting wrote:
> Nit: Can we just say:
> 
> Update the bookmark bar state, since the BrowserWindow may query it during
> OnActiveTabChanged() below.

Done.

[commit-bot: I haz the power, 2013-10-02 00:16:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kuan@chromium.org/25500003/15001

[commit-bot: I haz the power, 2013-10-02 01:49:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 10:17:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kuan@chromium.org/25500003/15001

[commit-bot: I haz the power, 2013-10-02 12:19:08]

Change committed as 226454