Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2549863002: [Mac] Fixed permission bubble position in fullscreen (Closed)

Created:
4 years ago by spqchan
Modified:
4 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fixed permission bubble position in fullscreen BUG=670254 Committed: https://crrev.com/72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf Cr-Commit-Position: refs/heads/master@{#436062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
spqchan
PTAL
4 years ago (2016-12-02 19:36:07 UTC) #2
Robert Sesek
lgtm
4 years ago (2016-12-02 20:00:25 UTC) #3
spqchan
On 2016/12/02 20:00:25, Robert Sesek wrote: > lgtm thanks!
4 years ago (2016-12-02 21:52:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549863002/1
4 years ago (2016-12-02 21:52:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 22:45:17 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 22:47:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf
Cr-Commit-Position: refs/heads/master@{#436062}

Powered by Google App Engine
This is Rietveld 408576698