Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2549843002: Manually rebaseline NeedsRebaselines on or before 12/1 (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
qyearsley
CC:
chromium-reviews, caseq+blink_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, yzshen+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin (slow to review), mac-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually rebaseline NeedsRebaselines on or before 12/1 This is done in the following steps: 1. Replace [ NeedsRebaseline ] with [ Rebaseline ] 2. run webkit-patch rebaseline-expectations 3. Remove the [ PRECISE ] lines from TestExpectations (caused by 660580). For console-stack-overflow-source-url.html, because it's flaky, marked it flaky instead of rebaselining. BUG=662722, 666628, 664782, 475556 TBR=rebaseline under webexposed/ as the NeedsRebaselines have already been approved. Committed: https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47 Cr-Commit-Position: refs/heads/master@{#436042}

Patch Set 1 #

Patch Set 2 : console-stack-overflow-source-url.html is flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -7914 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 3 chunks +2 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/huge-image-viewport-scale-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css1/pseudo/anchor-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-scalable-background-image2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -7738 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/css1/pseudo/anchor-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/basic/grouping-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_left_width-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_top_inline-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/pseudo/anchor-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-scalable-background-image1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css1/pseudo/anchor-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/wicd/test-scalable-background-image2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css1/pseudo/anchor-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 4 chunks +268 lines, -142 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image2-expected.png View Binary file 0 comments Download

Messages

Total messages: 22 (15 generated)
Xianzhu
4 years ago (2016-12-02 18:38:58 UTC) #2
qyearsley
LGTM if layout tests pass on all platforms after this :-)
4 years ago (2016-12-02 18:39:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549843002/20001
4 years ago (2016-12-02 20:54:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/317724)
4 years ago (2016-12-02 21:04:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549843002/20001
4 years ago (2016-12-02 21:10:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 22:09:41 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-02 22:11:10 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47
Cr-Commit-Position: refs/heads/master@{#436042}

Powered by Google App Engine
This is Rietveld 408576698