Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: net/base/mime_util.h

Issue 254983006: Fix: Adding list of supported codecs for MP4 containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/mime_util.h
diff --git a/net/base/mime_util.h b/net/base/mime_util.h
index 9662e9656e397de2d48adedbfae590a3249ff4a7..e5a34795df43c6f5349682c7763a93d6a8698de6 100644
--- a/net/base/mime_util.h
+++ b/net/base/mime_util.h
@@ -76,12 +76,16 @@ NET_EXPORT void ParseCodecString(const std::string& codecs,
// certain subset of codecs.
NET_EXPORT bool IsStrictMediaMimeType(const std::string& mime_type);
+enum CanPlayType { IsNotSupported, IsSupported, MayBeSupported };
+
// Check to see if a particular MIME type is in our list which only supports a
-// certain subset of codecs. Returns true if and only if all codecs are
-// supported for that specific MIME type, false otherwise. If this returns
-// false you will still need to check if the media MIME tpyes and codecs are
-// supported.
-NET_EXPORT bool IsSupportedStrictMediaMimeType(
+// certain subset of codecs.
+// * Returns IsSupported if and only if all the codecs are supported for that
+// specific MIME type.
+// * Returns MayBeSupported if codecs paramter is empty or has a profile
+// parameter which can't be decided whether it is supported or not.
+// * Returns IsNotSupported if none of the aforementioned conditions are met.
+NET_EXPORT CanPlayType IsSupportedStrictMediaMimeType(
const std::string& mime_type,
const std::vector<std::string>& codecs);

Powered by Google App Engine
This is Rietveld 408576698