Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.cc

Issue 254983006: Fix: Adding list of supported codecs for MP4 containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test for wrong extended codecs Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/renderer_webkitplatformsupport_impl.cc
diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc
index ceb6850e3f7a130d417506c591632c510204d96a..6bad6395e4e5495940e2b0e237bcde57711173c1 100644
--- a/content/renderer/renderer_webkitplatformsupport_impl.cc
+++ b/content/renderer/renderer_webkitplatformsupport_impl.cc
@@ -425,8 +425,7 @@ RendererWebKitPlatformSupportImpl::MimeRegistry::supportsMediaMIMEType(
std::string key_system_ascii =
GetUnprefixedKeySystemName(base::UTF16ToASCII(key_system));
std::vector<std::string> strict_codecs;
- bool strip_suffix = !net::IsStrictMediaMimeType(mime_type_ascii);
- net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, strip_suffix);
+ net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, true);
if (!IsSupportedKeySystemWithMediaMimeType(
mime_type_ascii, strict_codecs, key_system_ascii)) {
@@ -441,14 +440,8 @@ RendererWebKitPlatformSupportImpl::MimeRegistry::supportsMediaMIMEType(
// Check if the codecs are a perfect match.
std::vector<std::string> strict_codecs;
net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, false);
- if (net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs))
- return IsSupported;
-
- // We support the container, but no codecs were specified.
- if (codecs.isNull())
- return MayBeSupported;
-
- return IsNotSupported;
+ return static_cast<WebMimeRegistry::SupportsType> (
+ net::IsSupportedStrictMediaMimeType(mime_type_ascii,strict_codecs));
ddorwin 2014/05/20 17:47:27 nit: space after ','
amogh.bihani 2014/05/21 04:38:05 Done.
}
// If we don't recognize the codec, it's possible we support it.

Powered by Google App Engine
This is Rietveld 408576698