Fix: Adding list of supported codecs for MP4 containers

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/memory/shared_memory.h"
@@ skipping 420 matching lines @@
   }
 
   // Check list of strict codecs to see if it is supported.
   if (net::IsStrictMediaMimeType(mime_type_ascii)) {
     // Check if the codecs are a perfect match.
     std::vector<std::string> strict_codecs;
     net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, false);
     if (net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs))
       return IsSupported;
 
+    // H.264 codecs have profile version in their names.

[ddorwin, 2014/04/29 17:12:54]

H.264 does not match the function name.

+    if (net::IsSupportedStrictMP4MediaMimeType(mime_type_ascii, strict_codecs))

[ddorwin, 2014/04/29 17:12:54]

You might also comment that since we do not check for exact profile versions, we
will only return maybe.

However, it would really be better to have the function make that determination.
(The current implementation would always return maybe, but this code shouldn't
need to know that.) Then you wouldn't need the comment.

+      return MayBeSupported;
+
     // We support the container, but no codecs were specified.
     if (codecs.isNull())
       return MayBeSupported;
 
     return IsNotSupported;
   }
 
   // If we don't recognize the codec, it's possible we support it.
   std::vector<std::string> parsed_codecs;
   net::ParseCodecString(ToASCIIOrEmpty(codecs), &parsed_codecs, true);
@@ skipping 720 matching lines @@
     return;
   QuotaDispatcher::ThreadSpecificInstance(
       thread_safe_sender_.get(),
       quota_message_filter_.get())->QueryStorageUsageAndQuota(
           storage_partition,
           static_cast<quota::StorageType>(type),
           QuotaDispatcher::CreateWebStorageQuotaCallbacksWrapper(callbacks));
 }
 
 }  // namespace content