Fix: Adding list of supported codecs for MP4 containers

net/base/mime_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_MIME_UTIL_H__
 #define NET_BASE_MIME_UTIL_H__
 
 #include <string>
 #include <vector>
 
@@ skipping 76 matching lines @@
 // |codecs_out| will contain {"aaa.b.c", "dd.eee"}.
 // See http://www.ietf.org/rfc/rfc4281.txt.
 NET_EXPORT void ParseCodecString(const std::string& codecs,
                                  std::vector<std::string>* codecs_out,
                                  bool strip);
 
 // Check to see if a particular MIME type is in our list which only supports a
 // certain subset of codecs.
 NET_EXPORT bool IsStrictMediaMimeType(const std::string& mime_type);
 
-// Check to see if a particular MIME type is in our list which only supports a
-// certain subset of codecs. Returns true if and only if all codecs are
-// supported for that specific MIME type, false otherwise. If this returns
-// false you will still need to check if the media MIME tpyes and codecs are
-// supported.
-NET_EXPORT bool IsSupportedStrictMediaMimeType(
+// Indicates that the MIME type and (possible codec string) are supported by the
+// underlying platform.
+// IsNotSupported - The underlying platform is known not to support the given
+//                  MIME type and codec combination.
+// IsSuported     - The underlying platform is known to support the given MIME
+//                  type and codec combination.
+// MayBeSupported - The underlying platform is unsure whether the given MIME
+//                  type and codec combination can be rendered or not before
+//                  actually trying to play it.

[Ryan Sleevi, 2014/06/12 19:03:53]

Document these inline, as suggested

// Comment describing SupportsType
enum SupportsType {
  // Comment describing IsNotSupported
  IsNotSupported,

  // Comment describing IsSupported
  IsSupported,

  // Comment describing MayBeSupported
  MayBeSupported
};

+enum SupportsType {
+  IsNotSupported,
+  IsSupported,
+  MayBeSupported
+};
+
+// Checks the |mime_type| and |codecs| against the MIME types known to support
+// only a particular subset of codecs.
+// * Returns IsSupported if the |mime_type| is supported and all the codecs
+//   within the |codecs| are supported for the |mime_type|.
+// * Returns MayBeSupported if the |mime_type| is supported and is known to
+//   support only a subset of codecs, but |codecs| was empty. Also returned if a
+//   codec is supported, but additional codec parameters were supplied (such as
+//   profile) for which the support cannot be decided.

[Ryan Sleevi, 2014/06/12 19:03:53]

Still doesn't document what happens in the case of

codecs { A, B.UnsupportedProfile, C }

where A is supported, B MAY be supported, and C is not supported.

Suggested resolution:

"Also returned if all of the codecs listed in |codec| are supported, but
additional codec parameters were supplied (such as a profile) for which support
cannot be decided"

+// * Returns IsNotSupported if either the |mime_type| is not supported or the
+//   |mime_type| is supported but atleast one of the codecs within |codecs| is

[Ryan Sleevi, 2014/06/12 19:03:53]

s/atleast/at least/

+//   not supported for the |mime_type|.
+NET_EXPORT SupportsType IsSupportedStrictMediaMimeType(
     const std::string& mime_type,
     const std::vector<std::string>& codecs);
 
 // Get the extensions associated with the given mime type. This should be passed
 // in lower case. There could be multiple extensions for a given mime type, like
 // "html,htm" for "text/html", or "txt,text,html,..." for "text/*".
 // Note that we do not erase the existing elements in the the provided vector.
 // Instead, we append the result to it.
 NET_EXPORT void GetExtensionsForMimeType(
     const std::string& mime_type,
@@ skipping 29 matching lines @@
                                            std::string* post_data);
 
 // Adds the final delimiter to a multi-part upload request.
 NET_EXPORT void AddMultipartFinalDelimiterForUpload(
     const std::string& mime_boundary,
     std::string* post_data);
 
 }  // namespace net
 
 #endif  // NET_BASE_MIME_UTIL_H__