Fix: Adding list of supported codecs for MP4 containers

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/memory/shared_memory.h"
@@ skipping 407 matching lines @@
   if (!key_system.isEmpty()) {
     // Check whether the key system is supported with the mime_type and codecs.
 
     // Chromium only supports ASCII parameters.
     if (!base::IsStringASCII(key_system))
       return IsNotSupported;
 
     std::string key_system_ascii =
         GetUnprefixedKeySystemName(base::UTF16ToASCII(key_system));
     std::vector<std::string> strict_codecs;
-    bool strip_suffix = !net::IsStrictMediaMimeType(mime_type_ascii);
-    net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, strip_suffix);
+    net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, true);
 
     if (!IsSupportedKeySystemWithMediaMimeType(
             mime_type_ascii, strict_codecs, key_system_ascii)) {
       return IsNotSupported;
     }
 
     // Continue processing the mime_type and codecs.
   }
 
   // Check list of strict codecs to see if it is supported.
   if (net::IsStrictMediaMimeType(mime_type_ascii)) {
     // Check if the codecs are a perfect match.
     std::vector<std::string> strict_codecs;
     net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, false);
-    if (net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs))
-      return IsSupported;
-
-    // We support the container, but no codecs were specified.
-    if (codecs.isNull())
-      return MayBeSupported;
-
-    return IsNotSupported;
+    return static_cast<WebMimeRegistry::SupportsType> (

[acolwell GONE FROM CHROMIUM, 2014/06/02 21:22:42]

You should add COMPILE_ASSERTS to content/public/common/assert_matching_enums.cc
that verify that the WebMimeRegistry::SupportsType values always match the
CanPlayType values. You might also consider renaming the CanPlayType enum since
nothing at this level actually refers to canPlayType(). Having the same or a
similar name to SupportsType would be better.

[amogh.bihani, 2014/06/03 13:26:12]

Done.

+        net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs));
   }
 
   // If we don't recognize the codec, it's possible we support it.
   std::vector<std::string> parsed_codecs;
   net::ParseCodecString(ToASCIIOrEmpty(codecs), &parsed_codecs, true);
   if (!net::AreSupportedMediaCodecs(parsed_codecs))
     return MayBeSupported;
 
   // Otherwise we have a perfect match.
   return IsSupported;
@@ skipping 738 matching lines @@
 void RendererWebKitPlatformSupportImpl::setBatteryStatusListener(
     blink::WebBatteryStatusListener* listener) {
   if (!battery_status_dispatcher_) {
     battery_status_dispatcher_.reset(
         new BatteryStatusDispatcher(RenderThreadImpl::current()));
   }
   battery_status_dispatcher_->SetListener(listener);
 }
 
 }  // namespace content