Fix: Adding list of supported codecs for MP4 containers

net/base/mime_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_MIME_UTIL_H__
 #define NET_BASE_MIME_UTIL_H__
 
 #include <string>
 #include <vector>
 
@@ skipping 58 matching lines @@
 // |codecs_out| will contain {"aaa.b.c", "dd.eee"}.
 // See http://www.ietf.org/rfc/rfc4281.txt.
 NET_EXPORT void ParseCodecString(const std::string& codecs,
                                  std::vector<std::string>* codecs_out,
                                  bool strip);
 
 // Check to see if a particular MIME type is in our list which only supports a
 // certain subset of codecs.
 NET_EXPORT bool IsStrictMediaMimeType(const std::string& mime_type);
 
+enum CanPlayType { IsNotSupported, IsSupported, MayBeSupported };
+
 // Check to see if a particular MIME type is in our list which only supports a
 // certain subset of codecs. Returns true if and only if all codecs are
 // supported for that specific MIME type, false otherwise. If this returns
 // false you will still need to check if the media MIME tpyes and codecs are
 // supported.

[Ryan Sleevi, 2014/05/15 22:48:35]

This comment block is now out of date and needs to be updated.

This "smells" like a layering violation though - letting details about Blink
seep into net/.

[amogh.bihani, 2014/05/16 11:25:29]

done.
That's why I had made a new method for checking MP4 and HLS mime types. Acolwell
had advised to change this to return enum. This does look cleaner than my
previous approach.

-NET_EXPORT bool IsSupportedStrictMediaMimeType(
+NET_EXPORT CanPlayType IsSupportedStrictMediaMimeType(
     const std::string& mime_type,
     const std::vector<std::string>& codecs);
 
 // Get the extensions associated with the given mime type. This should be passed
 // in lower case. There could be multiple extensions for a given mime type, like
 // "html,htm" for "text/html", or "txt,text,html,..." for "text/*".
 // Note that we do not erase the existing elements in the the provided vector.
 // Instead, we append the result to it.
 NET_EXPORT void GetExtensionsForMimeType(
     const std::string& mime_type,
@@ skipping 29 matching lines @@
                                            std::string* post_data);
 
 // Adds the final delimiter to a multi-part upload request.
 NET_EXPORT void AddMultipartFinalDelimiterForUpload(
     const std::string& mime_boundary,
     std::string* post_data);
 
 }  // namespace net
 
 #endif  // NET_BASE_MIME_UTIL_H__