Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4985)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 254983005: [Sheriff] Disable FindRestarts_Issue70505 for being flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index a64f211799dedc619958d0a85134d91772d74002..3af1373182ed572096682d48b64eac3c58d955bd 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -797,9 +797,17 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindRestarts_Issue1155639) {
EXPECT_EQ(1, ordinal);
}
+// Disable the test for win and mac as it started being flaky, see
+// http://crbug/367701.
+#if defined(OS_MACOSX) && !defined(OS_IOS) || defined(OS_WIN)
+#define MAYBE_FindRestarts_Issue70505 DISABLED_FindRestarts_Issue70505
+#else
+#define MAYBE_FindRestarts_Issue70505 FindRestarts_Issue70505
+#endif
// Make sure we don't get into an infinite loop when text box contains very
// large amount of text.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindRestarts_Issue70505) {
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
+ MAYBE_FindRestarts_Issue70505) {
// First we navigate to our page.
GURL url = GetURL(kLongTextareaPage);
ui_test_utils::NavigateToURL(browser(), url);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698