Add function to compute proportional set size for OS_WIN

components/tracing/common/process_metrics_memory_dump_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/tracing/common/process_metrics_memory_dump_provider.h"
 
 #include <fcntl.h>
 #include <stdint.h>
 
 #include <map>
@@ skipping 280 matching lines @@
       is_rss_peak_resettable_ = false;
     }
     close(clear_refs_fd);
   }
 #elif defined(MACOSX)
   size_t private_bytes;
   bool res = process_metrics_->GetMemoryBytes(&private_bytes,
                                               nullptr /* shared_bytes */);
   if (res)
     pmd->process_totals()->SetExtraFieldInBytes("private_bytes", private_bytes);
+#elif defined(OS_WIN)
+  if (args.level_of_detail ==
+      base::trace_event::MemoryDumpLevelOfDetail::DETAILED) {
+    uint64_t pss_bytes = 0;
+    bool res = process_metrics_->GetProportionalSetSizeBytes(&pss_bytes);
+    if (res) {
+      base::trace_event::ProcessMemoryMaps::VMRegion region;

[Primiano Tucci (use gerrit), 2016/12/06 17:47:57]

If I read the code correctly now within this function we are grabbing and
iterating over WorkingSetInformationBuffer twice:
once up in line 268 upon GetWorkingSetSize() and once here.
Is there a way we could expose/wrap the WorkingSetInformationBuffer, or the
result of postprocessing it?

[chengx, 2016/12/06 19:40:09]

My understanding is that line 268 calls GetWorkingSetSize() defined in
process_metrics_win.cc. GetWorkingSetSize() itself calls a WinAPI
GetProcessMemoryInfo. It seems WorkingSetInformationBuffer is not involved here.
Please correct me if I am wrong.

[Primiano Tucci (use gerrit), 2016/12/08 16:36:01]

Ahh you are right. I confused GetWorkingSetSize() with GetWorkingSetKBytes()
when reading the code. the latter does use the WSIBuffer. So you are right it's
all good.

+      region.byte_stats_proportional_resident = pss_bytes;
+      pmd->process_mmaps()->AddVMRegion(region);
+    }
+  }
+
 #endif  // defined(OS_LINUX) || defined(OS_ANDROID)

[Primiano Tucci (use gerrit), 2016/12/06 17:47:57]

plz can you remove the comment from this #endif as it doesn't apply anymore
after the various #else branches? 

[chengx, 2016/12/06 19:40:09]

Done.

 #endif  // !defined(OS_IOS)
 
   pmd->process_totals()->set_resident_set_bytes(rss_bytes);
   pmd->set_has_process_totals();
   pmd->process_totals()->set_peak_resident_set_bytes(peak_rss_bytes);
 
   // Returns true even if other metrics failed, since rss is reported.
   return true;
 }
 
 }  // namespace tracing