Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2549793002: Add 'self_check' runtime for running self-checking unit tests (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index f84a5601688e88f58738040ff7428a7754d07570..848f9c1c2caf4fc5e00c30232926aee236bea548 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -121,6 +121,11 @@ class TestOptionsParser {
[ff | chrome | safari | ie9 | ie10 | ie11 | opera | chromeOnAndroid]:
Run JavaScript in the specified browser.
+ self_check: Pass each test or its compiled output to every file under
+ `pkg` whose name ends with `_self_check.dart`.
+ Each test is given to the self_check tester as a filename on stdin using
+ the batch-mode protocol.
+
none: No runtime, compile only (for example, used for dart2analyzer static
analysis tests).''',
['-r', '--runtime'],
@@ -144,6 +149,7 @@ class TestOptionsParser {
'safarimobilesim',
'ContentShellOnAndroid',
'DartiumOnAndroid',
+ 'self_check',
'none'
],
'vm'),
@@ -479,6 +485,17 @@ Note: currently only implemented for dart2js.''',
['--exclude-suite'],
defaultTestSelectors,
null),
+ new _TestOptionSpecification(
+ 'skip-compilation',
+ 'Skip the compilation step, using the compilation artifacts left in '
+ ' the output folder from a previous run.'
+ 'This flag will often cause false positves and negatives, but can be'
+ ' useful for quick-and-dirty offline testing when not making changes'
+ ' that affect the compiler.',
+ ['--skip-compilation'],
+ [],
+ false,
+ type: 'bool')
];
}
@@ -697,7 +714,7 @@ Note: currently only implemented for dart2js.''',
break;
case 'app_jit':
case 'dartk':
- validRuntimes = const ['vm'];
+ validRuntimes = const ['vm', 'self_check', 'none'];
break;
case 'precompiler':
case 'dartkp':
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698