Add 'self_check' runtime for running self-checking unit tests

tools/testing/dart/runtime_configuration.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library runtime_configuration;
 
+import 'dart:io' show Directory, File;
+
 import 'compiler_configuration.dart' show CommandArtifact;
 
 // TODO(ahe): Remove this import, we can precompute all the values required
 // from TestSuite once the refactoring is complete.
 import 'test_suite.dart' show TestSuite;
 
 import 'test_runner.dart' show Command, CommandBuilder;
 
 // TODO(ahe): I expect this class will become abstract very soon.
 class RuntimeConfiguration {
   // TODO(ahe): Remove this constructor and move the switch to
   // test_options.dart.  We probably want to store an instance of

[Bill Hesse, 2016/12/06 14:46:03]

Notice here he points out that the instance can even go into configuration, not
into the TestSuite instance.

Perhaps put into the comments that a single instance per test suite (or per
configuration) exists, so no mutable data should be changed in these instances
after construction.

[asgerf, 2016/12/06 15:41:49]

Good point. Done.

   // [RuntimeConfiguration] in [configuration] there.
   factory RuntimeConfiguration(Map configuration) {
     String runtime = configuration['runtime'];
     bool useBlobs = configuration['use_blobs'];
 
     switch (runtime) {
       case 'ContentShellOnAndroid':
       case 'DartiumOnAndroid':
       case 'chrome':
       case 'chromeOnAndroid':
@@ skipping 23 matching lines @@
 
       case 'dart_precompiled':
         if (configuration['system'] == 'android') {
           return new DartPrecompiledAdbRuntimeConfiguration(useBlobs: useBlobs);
         }
         return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs);
 
       case 'drt':
         return new DrtRuntimeConfiguration();
 
+      case 'self_check':
+        return new SelfCheckRuntimeConfiguration();
+
       default:
         throw "Unknown runtime '$runtime'";
     }
   }
 
   RuntimeConfiguration._subclass();
 
   int computeTimeoutMultiplier(
       {String mode, bool isChecked: false, bool isReload: false, String arch}) {
     return 1;
   }
 
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
     // TODO(ahe): Make this method abstract.
     throw "Unimplemented runtime '$runtimeType'";
   }
 
   List<String> dart2jsPreambles(Uri preambleDir) => [];
+
+  bool get shouldSkipNegativeTests => false;
 }
 
 /// The 'none' runtime configuration.
 class NoneRuntimeConfiguration extends RuntimeConfiguration {
   NoneRuntimeConfiguration() : super._subclass();
 
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
@@ skipping 185 matching lines @@
     return <Command>[
       commandBuilder.getAdbPrecompiledCommand(precompiledRunner,
                                               processTest,
                                               script,
                                               arguments,
                                               useBlobs)
     ];
   }
 }
 
+class SelfCheckRuntimeConfiguration extends DartVmRuntimeConfiguration {
+  final List<String> selfCheckers = <String>[];
+
+  SelfCheckRuntimeConfiguration() {
+    searchForSelfCheckers();
+  }
+
+  void searchForSelfCheckers() {
+    for (var entry in new Directory('pkg').listSync(recursive: true)) {

[Bill Hesse, 2016/12/06 14:46:03]

Please use the test utils to specify the full path to 'pkg':

TestUtils.dartDirUri.resolve('pkg').toFilePath()
or
TestUtils.dartDir.append('pkg').toNativePath()
instead of just 'pkg'.

also show TestUtils from test_suite.
We shouldn't assume the current directory.

[asgerf, 2016/12/06 15:41:49]

Done.

+      if (entry is File && entry.path.endsWith('_self_check.dart')) {
+        selfCheckers.add(entry.path);
+      }
+    }
+  }
+
+  List<Command> computeRuntimeCommands(
+      TestSuite suite,
+      CommandBuilder commandBuilder,
+      CommandArtifact artifact,
+      List<String> arguments,
+      Map<String, String> environmentOverrides) {
+    String executable = suite.dartVmBinaryFileName;
+    return selfCheckers
+        .map((String tester) => commandBuilder.getSelfCheckCommand(
+            executable, tester, arguments, environmentOverrides,
+            checked: suite.configuration['checked']))
+        .toList();
+  }
+
+  @override
+  bool get shouldSkipNegativeTests => true;
+}
+
 /// Temporary runtime configuration for browser runtimes that haven't been
 /// migrated yet.
 // TODO(ahe): Remove this class.
 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
   List<Command> computeRuntimeCommands(
       TestSuite suite,
       CommandBuilder commandBuilder,
       CommandArtifact artifact,
       List<String> arguments,
       Map<String, String> environmentOverrides) {
     throw "Unimplemented runtime '$runtimeType'";
   }
 }