src/objects-body-descriptors-inl.h - Issue 2549773002: Internalize strings in-place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-body-descriptors-inl.h

Issue 2549773002: Internalize strings in-place (Closed)

Patch Set: fix performance Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-body-descriptors-inl.h

diff --git a/src/objects-body-descriptors-inl.h b/src/objects-body-descriptors-inl.h

index bffc8bdb3ef384302cf749236227aa036014581d..608d1847b9054edb765f937aa80a770507427bbd 100644

--- a/src/objects-body-descriptors-inl.h

+++ b/src/objects-body-descriptors-inl.h

@@ -440,6 +440,8 @@ ReturnType BodyDescriptorApply(InstanceType type, T1 p1, T2 p2, T3 p3) {

return ReturnType();

case kConsStringTag:

return Op::template apply<ConsString::BodyDescriptor>(p1, p2, p3);

+ case kThinStringTag:

+ return Op::template apply<ThinString::BodyDescriptor>(p1, p2, p3);

case kSlicedStringTag:

return Op::template apply<SlicedString::BodyDescriptor>(p1, p2, p3);

case kExternalStringTag: